WMDE-leszek has submitted this change and it was merged.
Change subject: Add labels to revision tooltips.
......................................................................
Add labels to revision tooltips.
This adds labels for user, comment and article size to the revision
tooltip as well as the respective messages needed for the labels.
Bug: T135740
Change-Id: Ia65fb0bbbe3eb2405665d784bad157ea059e2d6e
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.RevisionSlider.RevisionListView.js
4 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 24f96ca..e1e92ef 100755
--- a/extension.json
+++ b/extension.json
@@ -108,7 +108,10 @@
"modules/ext.RevisionSlider.RevisionListView.js"
],
"messages": [
- "revisionslider-revision-bytes"
+ "revisionslider-revision-bytes",
+ "revisionslider-label-article-size",
+ "revisionslider-label-user",
+ "revisionslider-label-comment"
]
},
"ext.RevisionSlider.pointers.lower": {
diff --git a/i18n/en.json b/i18n/en.json
index b9eca7a..577e5b3 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -9,6 +9,9 @@
"revisionslider-beta-feature-message": "Revision Slider",
"revisionslider-beta-feature-description": "Show a revision slider when
comparing two revisions of a page.",
"revisionslider-revision-bytes": "$1 {{PLURAL:$1|byte|bytes}}",
+ "revisionslider-label-article-size": "Article size: $1",
+ "revisionslider-label-comment": "Comment: $1",
+ "revisionslider-label-user": "User: $1",
"revisionslider-loading-placeholder": "The revision slider is loading.",
"revisionslider-loading-failed": "The revision slider failed to load.",
"revisionslider-loading-out-of-range": "The revision slider failed to load
as the requested revisions are not in the top 500 versions of the page.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 3a12104..eca0762 100755
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -9,6 +9,9 @@
"revisionslider-beta-feature-message": "Label for the revision slider
Beta Feature.",
"revisionslider-beta-feature-description": "Description for the
revision slider Beta Feature, describing the feature that will be enabled.",
"revisionslider-revision-bytes": "Label describing the amount of bytes
changed in this revision.\nParameters:\n* $1 - Revision size in bytes.",
+ "revisionslider-label-article-size": "Label describing the size of this
revision.\nParameters:\n* $1 - Revision size.",
+ "revisionslider-label-comment": "Label showing the edit summary of a
revision.\nParameters:\n* $1 - The revision's edit summary.",
+ "revisionslider-label-user": "Label showing this revision's author's
username.\nParameters:\n* $1 - Username.",
"revisionslider-loading-placeholder": "Message shown while the
RevisionSlider is still loading on a diff page. Once loaded the message is
removed.",
"revisionslider-loading-failed": "Message shown if the RevisionSlider
fails to initially load.",
"revisionslider-loading-out-of-range": "Message shown if the
RevisionSlider fails to initially load due to revisions being requested that
are not in the most recent 500 revisions.",
diff --git a/modules/ext.RevisionSlider.RevisionListView.js
b/modules/ext.RevisionSlider.RevisionListView.js
index 5f6a3fb..9e3d05c 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -55,9 +55,19 @@
makeTooltip: function ( rev ) {
var $tooltip = $( '<div/>' )
.append( '<p><b>' + rev.getFormattedDate() +
'</b></p>' )
- .append( $( '<bdi/>' ).append( $( '<p/>'
).text( mw.html.escape( rev.getUser() ) ) ) )
- .append( rev.getComment() ? $( '<bdi/>'
).append( $( '<p/>' ).append( '<i/>' ).text( mw.html.escape( rev.getComment() )
) ) : '' )
- .append( $( '<p/>' ).html( mw.msg(
'revisionslider-revision-bytes', rev.getSize() ) ) )
+ .append( $( '<bdi/>' ).append( $( '<p/>' ).text(
+ mw.msg( 'revisionslider-label-user',
mw.html.escape( rev.getUser() ) )
+ ) ) )
+ .append(
+ rev.getComment() ?
+ $( '<bdi/>' ).append( $( '<p/>'
).append( $( '<i/>' ).text(
+ mw.msg(
'revisionslider-label-comment', mw.html.escape( rev.getComment() ) )
+ ) ) )
+ : ''
+ )
+ .append( $( '<p/>' ).html(
+ mw.msg(
'revisionslider-label-article-size', mw.msg( 'revisionslider-revision-bytes',
rev.getSize() ) )
+ ) )
.append( rev.isMinor() ? $( '<p/>' ).html(
mw.message( 'minoredit' ).text() ) : '' );
return $tooltip.html();
--
To view, visit https://gerrit.wikimedia.org/r/290931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia65fb0bbbe3eb2405665d784bad157ea059e2d6e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Jakob <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
