jenkins-bot has submitted this change and it was merged.
Change subject: Clear save caches when toolbar is re-attached
......................................................................
Clear save caches when toolbar is re-attached
Change-Id: I14ddcba9fa4fd5f39341312d241ce59980276a2b
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 7dd392d..4cc8e45 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -913,6 +913,7 @@
// Clear the cached HTML and cache key once the document changes
if ( this.getSurface() ) {
this.getSurface().getModel().getDocument().once( 'transact',
clear );
+ this.getSurface().once( 'destroy', clear );
} else {
clear();
}
@@ -1472,6 +1473,11 @@
this.setupToolbarSaveButton();
this.attachToolbarSaveButton();
+
+ if ( this.saveDialog ) {
+ this.saveDialog.disconnect( this );
+ this.saveDialog = null;
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/290919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14ddcba9fa4fd5f39341312d241ce59980276a2b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
