Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290996
Change subject: mediawiki.special.recentchanges: Use module.exports instead of
mw.special
......................................................................
mediawiki.special.recentchanges: Use module.exports instead of mw.special
This isn't generally used as a public method. The only reason it's exposed is
for an integration test to acces it.
This commit and others prepare for removal of the 'mediawiki.special.js' file.
This script does nothing other than create "mw.special = {};". While that init
pattern is common in extensions and not wrong, 'mediawiki.special' violates
T92459 due to having styles. Given there's only script uses of it, easiest to
remove in favour of the new module export pattern.
Change-Id: I2e78828828601e1160550efe02c07172ac32e985
---
M resources/Resources.php
M resources/src/mediawiki.special/mediawiki.special.recentchanges.js
M
tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/96/290996/1
diff --git a/resources/Resources.php b/resources/Resources.php
index bacf1e6..4d5173f 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1880,7 +1880,6 @@
],
'mediawiki.special.recentchanges' => [
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.recentchanges.js',
- 'dependencies' => 'mediawiki.special',
'position' => 'top',
],
'mediawiki.special.search' => [
diff --git a/resources/src/mediawiki.special/mediawiki.special.recentchanges.js
b/resources/src/mediawiki.special/mediawiki.special.recentchanges.js
index d43b62b..bdd45bc 100644
--- a/resources/src/mediawiki.special/mediawiki.special.recentchanges.js
+++ b/resources/src/mediawiki.special/mediawiki.special.recentchanges.js
@@ -34,6 +34,6 @@
$( rc.init );
- mw.special.recentchanges = rc;
+ module.exports = rc;
}( mediaWiki, jQuery ) );
diff --git
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
index ee854ae..edc2716 100644
---
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
+++
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
@@ -4,7 +4,8 @@
// TODO: verify checkboxes == [ 'nsassociated', 'nsinvert' ]
QUnit.test( '"all" namespace disable checkboxes', 8, function ( assert
) {
- var selectHtml, $env, $options;
+ var selectHtml, $env, $options,
+ rc = require( 'mediawiki.special.recentchanges' );
// from Special:Recentchanges
selectHtml = '<select id="namespace" name="namespace"
class="namespaceselector">'
@@ -32,7 +33,7 @@
assert.strictEqual( $( '#nsassociated' ).prop( 'disabled' ),
false );
// Initiate the recentchanges module
- mw.special.recentchanges.init();
+ rc.init();
// By default
assert.strictEqual( $( '#nsinvert' ).prop( 'disabled' ), true );
--
To view, visit https://gerrit.wikimedia.org/r/290996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e78828828601e1160550efe02c07172ac32e985
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
