jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.special.apisandbox: Use module.exports instead of
mw.special
......................................................................
mediawiki.special.apisandbox: Use module.exports instead of mw.special
mw.special.ApiSandbox is not used anywhere, and it's an easy candidate for
converting to the new module export pattern.
This removes the last use of the 'mediawiki.special.js' file, which violates
T92459 due to having styles.
Change-Id: I9b6972d763f34d50479099d4d726d1c77a91c223
---
M resources/Resources.php
M resources/src/mediawiki.special/mediawiki.special.apisandbox.js
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index 4d5173f..2cc8c2e 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1737,7 +1737,6 @@
'styles' =>
'resources/src/mediawiki.special/mediawiki.special.apisandbox.css',
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.apisandbox.js',
'dependencies' => [
- 'mediawiki.special',
'mediawiki.api',
'mediawiki.jqueryMsg',
'oojs-ui',
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index 7aeafec..3d90307 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -557,7 +557,7 @@
*
* @class mw.special.ApiSandbox
*/
- mw.special.ApiSandbox = ApiSandbox = {
+ ApiSandbox = {
/**
* Initialize the UI
*
@@ -1674,4 +1674,6 @@
$( ApiSandbox.init );
+ module.exports = ApiSandbox;
+
}( jQuery, mediaWiki, OO ) );
--
To view, visit https://gerrit.wikimedia.org/r/290997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6972d763f34d50479099d4d726d1c77a91c223
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
