jenkins-bot has submitted this change and it was merged.
Change subject: Set 503 error code for 503 errors
......................................................................
Set 503 error code for 503 errors
The comment seems to be outdated, perhaps fixed in a
newer more recent nginx?
Bug: T136347
Change-Id: I840854e67c7a5169fe3252d48d6a5656804d197c
---
M www/index.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/www/index.php b/www/index.php
index 30458dd..3d18874 100644
--- a/www/index.php
+++ b/www/index.php
@@ -59,10 +59,8 @@
header( "Location: {$to}" );
exit( 0 );
}
- // This endpoint is called as an error hander page by
nginx, so
- // *DO NOT* return an actual 503 status code. If you do
nginx will
- // think that the error handler itself is broken.
include 'content/503.php';
+ http_response_code( 503 );
exit( 0 );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/291019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I840854e67c7a5169fe3252d48d6a5656804d197c
Gerrit-PatchSet: 2
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
