jenkins-bot has submitted this change and it was merged. Change subject: Simplify DatabaseBase::tableName() ......................................................................
Simplify DatabaseBase::tableName() - Removed isset() check for configuration setting since they are always defined - Removed triple check whether a database is already defined by putting everything in the same place - Simplify the construction of the result string Change-Id: Iaaf68149f16b1d38a038db1b41909464f29e2289 --- M includes/db/Database.php 1 file changed, 25 insertions(+), 33 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved Parent5446: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31875 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaf68149f16b1d38a038db1b41909464f29e2289 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
