Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291154

Change subject: Trim fields before sending to server
......................................................................

Trim fields before sending to server

Makes the logs look nicer

Change-Id: Ie441283b6d05c840dd1bf6c6c08a5fc6df88877c
---
M adyen_gateway/forms/js/adyen.js
M modules/js/ext.donationInterface.forms.js
M worldpay_gateway/forms/js/esop.js
3 files changed, 11 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/54/291154/1

diff --git a/adyen_gateway/forms/js/adyen.js b/adyen_gateway/forms/js/adyen.js
index 76622fd..8b61c01 100644
--- a/adyen_gateway/forms/js/adyen.js
+++ b/adyen_gateway/forms/js/adyen.js
@@ -3,6 +3,7 @@
 
        di.forms.submit = function () {
                di.forms.disable();
+               di.forms.clean();
                $( '#paymentContinueBtn' ).removeClass( 'enabled' );
 
                var sendData,
diff --git a/modules/js/ext.donationInterface.forms.js 
b/modules/js/ext.donationInterface.forms.js
index b3e5be2..41619ba 100644
--- a/modules/js/ext.donationInterface.forms.js
+++ b/modules/js/ext.donationInterface.forms.js
@@ -17,12 +17,21 @@
         */
        function submitForm() {
                di.forms.disable();
+               di.forms.clean();
                $( '#payment-form' )[ 0 ].submit();
+       }
+
+       function cleanInput() {
+               // Trim all the trimmable inputs
+               $( '[type=text], [type=number], [type=email]' ).each( function 
() {
+                       $( this ).val( $.trim( this.value ) );
+               } );
        }
 
        di.forms = {
                disable: disableForm,
                enable: enableForm,
+               clean: cleanInput,
                // Gateways with more complex form submission can overwrite this
                // property with their own submission function.
                submit: submitForm
diff --git a/worldpay_gateway/forms/js/esop.js 
b/worldpay_gateway/forms/js/esop.js
index b96d0e2..131b384 100644
--- a/worldpay_gateway/forms/js/esop.js
+++ b/worldpay_gateway/forms/js/esop.js
@@ -6,6 +6,7 @@
                        return;
                }
                di.forms.disable();
+               di.forms.clean();
                $( '#paymentContinueBtn' ).removeClass( 'enabled' );
 
                var postdata = {

-- 
To view, visit https://gerrit.wikimedia.org/r/291154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie441283b6d05c840dd1bf6c6c08a5fc6df88877c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to