jenkins-bot has submitted this change and it was merged.
Change subject: Allow video.js to overflow thumbinner
......................................................................
Allow video.js to overflow thumbinner
Alternative to the reverted I1953683
This uses JS to reset the overflow, and use an alternate method to
apply a block formatting context.
Bug: T132306
Change-Id: I690b13906cfec4baf82d80888f629388952189e8
---
M resources/ext.tmh.player.js
M resources/ext.tmh.player.styles.less
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.tmh.player.js b/resources/ext.tmh.player.js
index 5bab05b..e5763e0 100755
--- a/resources/ext.tmh.player.js
+++ b/resources/ext.tmh.player.js
@@ -111,6 +111,7 @@
$source.attr( 'res', $source.data( 'height' ) );
$source.attr( 'label', $source.data(
'shorttitle' ) );
} );
+ $videoplayer.parent( '.thumbinner' ).addClass(
'mw-overflow' );
// Launch the player
videojs( videoplayer, playerConfig ).ready( function ()
{
diff --git a/resources/ext.tmh.player.styles.less
b/resources/ext.tmh.player.styles.less
index 4e6d293..b4fa311 100644
--- a/resources/ext.tmh.player.styles.less
+++ b/resources/ext.tmh.player.styles.less
@@ -12,6 +12,13 @@
}
}
+div.thumbinner.mw-overflow {
+ /* We want to overflow, but we need to make sure we still
+ * create a new block formatting context */
+ overflow: visible;
+ display: table-cell;
+}
+
/*
* Make video-js behave like standard <video><audio> elements
* The thumbinner check works around a width interaction for
--
To view, visit https://gerrit.wikimedia.org/r/290821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I690b13906cfec4baf82d80888f629388952189e8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
