Jakob has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291240
Change subject: Show correct slider window after refresh when the last revision
is selected.
......................................................................
Show correct slider window after refresh when the last revision is selected.
This fixes a bug that would show a slider window where neither of
the pointers is visible after selecting the last revision of the current
window with the old revision pointer and then refreshing.
Change-Id: I15402d8ca7b8c783990a32e2d8426871763e20e1
---
M modules/ext.RevisionSlider.SliderView.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/40/291240/1
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 76a4f53..570a627 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -141,7 +141,7 @@
this.$element = $slider;
$container.html( $slider );
- this.slide( Math.floor( this.pointerTwo.getPosition() /
this.slider.getRevisionsPerWindow() ), 0 );
+ this.slide( Math.floor( ( this.pointerTwo.getPosition()
- 1 ) / this.slider.getRevisionsPerWindow() ), 0 );
this.diffPage.pushState(
mw.config.values.extRevisionSliderOldRev,
mw.config.values.extRevisionSliderNewRev, this );
this.diffPage.initOnPopState( this );
},
--
To view, visit https://gerrit.wikimedia.org/r/291240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15402d8ca7b8c783990a32e2d8426871763e20e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Jakob <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
