[MediaWiki-commits] [Gerrit] Fixes fail in PHP unit tests runned by CI - change (mediawiki...ProofreadPage)

[Tpt (Code Review)]

Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291488

Change subject: Fixes fail in PHP unit tests runned by CI
......................................................................

Fixes fail in PHP unit tests runned by CI

Change-Id: Ic606344a21ddd6fdcd74cee11c0487a89b88ddbd
---
M tests/includes/FileProviderTest.php
1 file changed, 22 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/88/291488/1

diff --git a/tests/includes/FileProviderTest.php 
b/tests/includes/FileProviderTest.php
index f298871..d2b7a9c 100644
--- a/tests/includes/FileProviderTest.php
+++ b/tests/includes/FileProviderTest.php
@@ -17,14 +17,26 @@
        /**
         * @var FileProvider
         */
-       protected $fileProvider;
+       private $fileProvider;
+
+       /**
+        * @var File
+        */
+       private $loremIpsumFile;
+
+       /**
+        * @var File
+        */
+       private $testFile;
 
        protected function setUp() {
                parent::setUp();
 
+               $this->loremIpsumFile = $this->getFileFromName( 
'LoremIpsum.djvu' );
+               $this->testFile = $this->getFileFromName( 'Test.jpg' );
                $this->fileProvider = new FileProviderMock( [
-                       $this->getFileFromName( 'LoremIpsum.djvu' ),
-                       $this->getFileFromName( 'Test.jpg' )
+                       $this->loremIpsumFile,
+                       $this->testFile
                ] );
        }
 
@@ -46,7 +58,7 @@
                return [
                        [
                                ProofreadIndexPage::newFromTitle( 
Title::makeTitle( 252, 'LoremIpsum.djvu' ) ),
-                               $this->getFileFromName( 'LoremIpsum.djvu' )
+                               $this->loremIpsumFile
                        ],
                ];
        }
@@ -55,7 +67,7 @@
         * @expectedException \ProofreadPage\FileNotFoundException
         * @dataProvider indexFileNotFoundProvider
         */
-       public function testGetForIndexPageWithFileNotFound( ProofreadIndexPage 
 $index ) {
+       public function testGetForIndexPageWithFileNotFound( ProofreadIndexPage 
$index ) {
                $this->fileProvider->getForIndexPage( $index );
        }
 
@@ -84,19 +96,19 @@
                return [
                        [
                                ProofreadPagePage::newFromTitle( 
Title::makeTitle( 250, 'LoremIpsum.djvu/4' ) ),
-                               $this->getFileFromName( 'LoremIpsum.djvu' )
+                               $this->loremIpsumFile
                        ],
                        [
                                ProofreadPagePage::newFromTitle( 
Title::makeTitle( 250, 'LoremIpsum.djvu/djvu/1' ) ),
-                               $this->getFileFromName( 'LoremIpsum.djvu' )
+                               $this->loremIpsumFile
                        ],
                        [
                                ProofreadPagePage::newFromTitle( 
Title::makeTitle( 250, 'LoremIpsum.djvu' ) ),
-                               $this->getFileFromName( 'LoremIpsum.djvu' )
+                               $this->loremIpsumFile
                        ],
                        [
                                ProofreadPagePage::newFromTitle( 
Title::makeTitle( 250, 'Test.jpg' ) ),
-                               $this->getFileFromName( 'Test.jpg' )
+                               $this->testFile
                        ],
                ];
        }
@@ -105,7 +117,7 @@
         * @expectedException \ProofreadPage\FileNotFoundException
         * @dataProvider pageFileNotFoundProvider
         */
-       public function testGetForPagePageWithFileNotFound( ProofreadPagePage  
$page ) {
+       public function testGetForPagePageWithFileNotFound( ProofreadPagePage 
$page ) {
                $this->fileProvider->getForPagePage( $page );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291488
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic606344a21ddd6fdcd74cee11c0487a89b88ddbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits