jenkins-bot has submitted this change and it was merged.
Change subject: Fix JS error when API request fails
......................................................................
Fix JS error when API request fails
We don't show an error message in this case, just an
empty popup, so that should be fixed regardless.
Bug: T136467
Change-Id: I06ddd5306bd8d7edeb8c75bdae7abd7215285e3d
---
M modules/ui/mw.echo.ui.NotificationsListWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ui/mw.echo.ui.NotificationsListWidget.js
b/modules/ui/mw.echo.ui.NotificationsListWidget.js
index 0da2479..70a3815 100644
--- a/modules/ui/mw.echo.ui.NotificationsListWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationsListWidget.js
@@ -194,7 +194,9 @@
itemWidgets = this.getItems();
for ( i = 0; i < itemWidgets.length; i++ ) {
- itemWidgets[ i ].resetInitiallyUnseen();
+ if ( itemWidgets[ i ].resetInitiallyUnseen ) {
+ itemWidgets[ i ].resetInitiallyUnseen();
+ }
}
};
} )( mediaWiki );
--
To view, visit https://gerrit.wikimedia.org/r/291672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06ddd5306bd8d7edeb8c75bdae7abd7215285e3d
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
