Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/291707
Change subject: base::grub: actually use augeas on jessie ...................................................................... base::grub: actually use augeas on jessie As the comment states, augeas on jessie has a fix for the backticks issue, so we can use it to configure /etc/default/grub. The version of augeas on jessie is 1.2.0 though. For reference see the issue: https://fedorahosted.org/augeas/ticket/377 Change-Id: Ie6ee99dc29c6779a0058d5379861728eb50b50dd --- M modules/base/manifests/grub.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/07/291707/1 diff --git a/modules/base/manifests/grub.pp b/modules/base/manifests/grub.pp index 835572e..3e89a49 100644 --- a/modules/base/manifests/grub.pp +++ b/modules/base/manifests/grub.pp @@ -1,7 +1,7 @@ class base::grub($ioscheduler = 'deadline') { # The shellvars_list lens is broken with backticks on older versions of # Augeas (< jessie), so keep a compatibility version with test/grep/sed - if versioncmp($::augeasversion, '1.3.0') >= 0 { + if versioncmp($::augeasversion, '1.2.0') >= 0 { augeas { 'grub2': incl => '/etc/default/grub', lens => 'Shellvars_list.lns', -- To view, visit https://gerrit.wikimedia.org/r/291707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6ee99dc29c6779a0058d5379861728eb50b50dd Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
