Faidon Liambotis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291726
Change subject: raid: always stringify the raid fact
......................................................................
raid: always stringify the raid fact
We do run Facter > 2.0.0 on jessie hosts, which correctly works with
returning an array, which is in turn written as an array in the
database. However, we do not run Puppet 4.0, or 3.7.5 with
stringify_facts explicitly turned off, so this is bound to cause some
problems.
Always stringify manually for now, until our stack gets newer across the
fleet, at which point we can revisit.
Change-Id: Ia421806c4fbedf2da4a02ba804fef990e647b38c
---
M modules/raid/lib/facter/raid.rb
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/26/291726/1
diff --git a/modules/raid/lib/facter/raid.rb b/modules/raid/lib/facter/raid.rb
index fdbddb6..fd4136b 100644
--- a/modules/raid/lib/facter/raid.rb
+++ b/modules/raid/lib/facter/raid.rb
@@ -50,11 +50,9 @@
raids.sort!.uniq!
- if Facter.version < '2.0.0'
- raids.join(',')
- else
- raids
- end
+ # stringify the fact to support Facter < 2.0.0 and/or puppet < 4.0
+ # (in the default config, 3.7.5 can also support structured facts)
+ raids.join(',')
end
end
--
To view, visit https://gerrit.wikimedia.org/r/291726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia421806c4fbedf2da4a02ba804fef990e647b38c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
