jenkins-bot has submitted this change and it was merged.
Change subject: Remove comment about solved EntityId vs. EntityIdValue problem
......................................................................
Remove comment about solved EntityId vs. EntityIdValue problem
This outdated comment should have been removed in
I8fba1e700fe435c96618c2ab75e3bebe5363561e three years ago. ;-)
Change-Id: I5bdd7b102a2fc7e066b0f648203a54ed2df24cca
---
M repo/includes/ValidatorBuilders.php
1 file changed, 4 insertions(+), 7 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/ValidatorBuilders.php
b/repo/includes/ValidatorBuilders.php
index 2282927..dfd8f79 100644
--- a/repo/includes/ValidatorBuilders.php
+++ b/repo/includes/ValidatorBuilders.php
@@ -132,13 +132,10 @@
* @return ValueValidator[]
*/
private function getEntityValidators( $entityType = null ) {
- $validators = array();
-
- //NOTE: The DataValue in question is going to be an instance of
EntityId!
- $validators[] = new TypeValidator( EntityIdValue::class );
- $validators[] = new EntityExistsValidator( $this->entityLookup,
$entityType );
-
- return $validators;
+ return [
+ new TypeValidator( EntityIdValue::class ),
+ new EntityExistsValidator( $this->entityLookup,
$entityType ),
+ ];
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/290654
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdd7b102a2fc7e066b0f648203a54ed2df24cca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
