jenkins-bot has submitted this change and it was merged.
Change subject: Remove the `mobile.buttonWithSpinner` module
......................................................................
Remove the `mobile.buttonWithSpinner` module
The module is not being used anywhere and there seems to be a
disagreement over its implementation. See the task for more info.
Bug: T95490
Change-Id: I42438c2ce2a5c1d0a45ef6b8177678608fd8e9b8
---
M extension.json
D resources/mobile.buttonWithSpinner/ButtonWithSpinner.js
D resources/mobile.buttonWithSpinner/ajax-loader.gif
D resources/mobile.buttonWithSpinner/buttonWithSpinner.less
4 files changed, 0 insertions(+), 63 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 5523db1..7d511b1 100644
--- a/extension.json
+++ b/extension.json
@@ -1203,21 +1203,6 @@
"mobile-frontend-watchlist-please-wait"
]
},
- "mobile.buttonWithSpinner": {
- "targets": [
- "mobile",
- "desktop"
- ],
- "dependencies": [
- "oojs-ui"
- ],
- "styles": [
-
"resources/mobile.buttonWithSpinner/buttonWithSpinner.less"
- ],
- "scripts": [
-
"resources/mobile.buttonWithSpinner/ButtonWithSpinner.js"
- ]
- },
"mobile.languages.structured": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
diff --git a/resources/mobile.buttonWithSpinner/ButtonWithSpinner.js
b/resources/mobile.buttonWithSpinner/ButtonWithSpinner.js
deleted file mode 100644
index de68b98..0000000
--- a/resources/mobile.buttonWithSpinner/ButtonWithSpinner.js
+++ /dev/null
@@ -1,40 +0,0 @@
-( function ( M ) {
- /**
- * Button with a spinner indicator
- * Behaves the same as OO.ui.Button widget. Also defines custom methods
that show and hide
- * the spinner.
- * @param {Object} config
- * @constructor
- */
- var ButtonWithSpinner = function ( config ) {
- ButtonWithSpinner.super.call( this, config );
- };
- OO.inheritClass( ButtonWithSpinner, OO.ui.ButtonWidget );
-
- /**
- * Show the spinner and hide the label (and save the label for future
use)
- */
- ButtonWithSpinner.prototype.showSpinner = function () {
- var originalWidth = this.$button.width();
-
- this.defaultLabel = this.getLabel();
- // Don't let the button width change
- this.$button.width( originalWidth );
- this
- .setIndicator( 'spinner' )
- .setLabel( '' )
- .setDisabled( true );
- };
-
- /**
- * Hide the spinner and show the default label
- */
- ButtonWithSpinner.prototype.hideSpinner = function () {
- this
- .setIndicator( null )
- .setLabel( this.defaultLabel )
- .setDisabled( false );
- };
-
- M.define( 'mobile.buttonWithSpinner/ButtonWithSpinner',
ButtonWithSpinner );
-}( mw.mobileFrontend ) );
diff --git a/resources/mobile.buttonWithSpinner/ajax-loader.gif
b/resources/mobile.buttonWithSpinner/ajax-loader.gif
deleted file mode 100644
index c519155..0000000
--- a/resources/mobile.buttonWithSpinner/ajax-loader.gif
+++ /dev/null
Binary files differ
diff --git a/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
b/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
deleted file mode 100644
index 109df07..0000000
--- a/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
+++ /dev/null
@@ -1,8 +0,0 @@
-@import 'minerva.mixins';
-
-.oo-ui-indicator-spinner {
- .background-image( 'ajax-loader.gif' );
- .background-size( 100%, 100% );
- margin-left: 0 !important;
- margin-right: 0 !important;
-}
--
To view, visit https://gerrit.wikimedia.org/r/291783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42438c2ce2a5c1d0a45ef6b8177678608fd8e9b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
