Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291828

Change subject: raid/hpssacli: don't barf on SATA + 6Gbps speed
......................................................................

raid/hpssacli: don't barf on SATA + 6Gbps speed

SATA 3.0 actually supports an 6.0Gbps rate and we have systems having
that (e.g. lvs1012). dsa-check-hpssacli currently warns about them
because it seems to support only up to 3.0Gbps. Add support for it.

SATA 3.2 goes up to 16Gbps but I have not seen this in the wild yet, so
it's unknown how hpssacli would display such a thing. Avoid guessing it
for now.

Change-Id: I9207136b9539df1d0af0714f60357c46e25b7f8d
---
M modules/raid/files/dsa-check-hpssacli
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/28/291828/1

diff --git a/modules/raid/files/dsa-check-hpssacli 
b/modules/raid/files/dsa-check-hpssacli
index 220d65b..4f97a52 100755
--- a/modules/raid/files/dsa-check-hpssacli
+++ b/modules/raid/files/dsa-check-hpssacli
@@ -245,7 +245,7 @@
                } elsif ($type eq 'SAS' || $type eq 'SAS+') {
                        $key = 'PHY Transfer Rate';
                        if ($value{'Interface Type'} eq 'SATA') {
-                               $expected = [ '1.5Gbps', '3.0Gbps' ];
+                               $expected = [ '1.5Gbps', '3.0Gbps', '6.0Gbps' ];
                        } elsif ($value{'PHY Count'} eq '2') {
                                if (defined($value{'Redundant Path(s)'})) {
                                        $expected = [ '3.0GBPS, 3.0GBPS', 
'6.0GBPS, 6.0GBPS',

-- 
To view, visit https://gerrit.wikimedia.org/r/291828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9207136b9539df1d0af0714f60357c46e25b7f8d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to