jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki theme: Adjacent disabled ButtonGroup/SelectWidget 
buttons border
......................................................................


MediaWiki theme: Adjacent disabled ButtonGroup/SelectWidget buttons border

Adding visible `border` to adjacent disabled
ButtonGroupWidget/ButtonSelectWidget buttons.
Also removing unnecessary `background-color` property.

Bug: T136571
Change-Id: I8418c3233dc0886b2662ea05265561bd53f030b1
---
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/widgets.less
2 files changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index e6da3d1..b704e02 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -144,10 +144,18 @@
                        }
                }
 
-               &.oo-ui-widget-disabled > .oo-ui-buttonElement-button {
-                       background-color: @background-color-filled-disabled;
-                       color: @color-disabled-framed;
-                       border: 1px solid @border-color-disabled;
+               &.oo-ui-widget-disabled {
+                       & > .oo-ui-buttonElement-button {
+                               background-color: 
@background-color-filled-disabled;
+                               color: @color-disabled-framed;
+                               border: 1px solid @border-color-disabled;
+                       }
+
+                       & + .oo-ui-widget-disabled {
+                               & > .oo-ui-buttonElement-button {
+                                       border-left-color: 
@color-disabled-framed;
+                               }
+                       }
                }
 
                &.oo-ui-widget-enabled {
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index c314a6e..1be715e 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -902,7 +902,6 @@
 
 .theme-oo-ui-buttonOptionWidget () {
        padding: 0;
-       background-color: transparent;
 
        &.oo-ui-optionWidget-selected,
        &.oo-ui-optionWidget-pressed,
@@ -1141,7 +1140,6 @@
 
 .theme-oo-ui-buttonSelectWidget () {
        border-radius: @border-radius-default;
-
        .oo-ui-inline-spacing( 0.5em );
 
        &:focus {

-- 
To view, visit https://gerrit.wikimedia.org/r/291823
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8418c3233dc0886b2662ea05265561bd53f030b1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz DziewoƄski <matma....@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Pginer <pgi...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to