jenkins-bot has submitted this change and it was merged. Change subject: Use cloneWithData ......................................................................
Use cloneWithData Change-Id: Ibab88f333cd39aabc73a579e1b05fc9b830b6d86 --- M modules/ve-cite/ve.dm.MWReferenceModel.js 1 file changed, 6 insertions(+), 20 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-cite/ve.dm.MWReferenceModel.js b/modules/ve-cite/ve.dm.MWReferenceModel.js index ecf35a9..6fbc5c8 100644 --- a/modules/ve-cite/ve.dm.MWReferenceModel.js +++ b/modules/ve-cite/ve.dm.MWReferenceModel.js @@ -226,26 +226,12 @@ if ( this.deferDoc ) { this.doc = this.deferDoc(); } else { - this.doc = new ve.dm.Document( - [ - { type: 'paragraph', internal: { generated: 'wrapper' } }, - { type: '/paragraph' }, - { type: 'internalList' }, - { type: '/internalList' } - ], - // htmlDocument - this.parentDoc.getHtmlDocument(), - // parentDocument - null, - // internalList - null, - // innerWhitespace - null, - // lang - this.parentDoc.getLang(), - // dir - this.parentDoc.getDir() - ); + this.doc = this.parentDoc.cloneWithData( [ + { type: 'paragraph', internal: { generated: 'wrapper' } }, + { type: '/paragraph' }, + { type: 'internalList' }, + { type: '/internalList' } + ] ); } } return this.doc; -- To view, visit https://gerrit.wikimedia.org/r/291830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibab88f333cd39aabc73a579e1b05fc9b830b6d86 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Cite Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits