jenkins-bot has submitted this change and it was merged.
Change subject: Use commandRegistry from current surface, not target
......................................................................
Use commandRegistry from current surface, not target
This shouldn't make a difference for any current implementations
but in the future different surfaces my have different commands.
Change-Id: I383a4a76cda142107da2f8aa1c6a90c4307e3b97
---
M modules/ve-cite/ve.ce.MWReferenceNode.js
M modules/ve-cite/ve.ui.MWReferenceDialog.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-cite/ve.ce.MWReferenceNode.js
b/modules/ve-cite/ve.ce.MWReferenceNode.js
index 86a566b..d90f457 100644
--- a/modules/ve-cite/ve.ce.MWReferenceNode.js
+++ b/modules/ve-cite/ve.ce.MWReferenceNode.js
@@ -103,7 +103,7 @@
if ( items.length ) {
contextItem = ve.ui.contextItemFactory.lookup( items[ 0 ].name
);
if ( contextItem ) {
- command = ve.init.target.commandRegistry.lookup(
contextItem.static.commandName );
+ command =
this.getRoot().getSurface().getSurface().commandRegistry.lookup(
contextItem.static.commandName );
if ( command ) {
command.execute(
this.focusableSurface.getSurface() );
}
diff --git a/modules/ve-cite/ve.ui.MWReferenceDialog.js
b/modules/ve-cite/ve.ui.MWReferenceDialog.js
index 8e65f20..3764677 100644
--- a/modules/ve-cite/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-cite/ve.ui.MWReferenceDialog.js
@@ -244,7 +244,7 @@
this.referenceTarget.destroy();
}
- citeCommands = Object.keys( ve.init.target.commandRegistry.registry
).filter( function ( command ) {
+ citeCommands = Object.keys(
ve.init.target.getSurface().commandRegistry.registry ).filter( function (
command ) {
return command.indexOf( 'cite-' ) !== -1;
} );
--
To view, visit https://gerrit.wikimedia.org/r/291832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I383a4a76cda142107da2f8aa1c6a90c4307e3b97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
