Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291852
Change subject: Make the notifications list the pending element
......................................................................
Make the notifications list the pending element
Change the pending element to be the notifications list rather than
the whole inbox widget in the Special:Notifications page.
Bug: T136581
Change-Id: I82b073c9cd628f30c13305510d6604e3ef636c2a
---
M modules/styles/mw.echo.ui.DatedNotificationsWidget.less
M modules/styles/mw.echo.ui.NotificationsInboxWidget.less
M modules/ui/mw.echo.ui.NotificationsInboxWidget.js
3 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/52/291852/1
diff --git a/modules/styles/mw.echo.ui.DatedNotificationsWidget.less
b/modules/styles/mw.echo.ui.DatedNotificationsWidget.less
index 20acc28..523568f 100644
--- a/modules/styles/mw.echo.ui.DatedNotificationsWidget.less
+++ b/modules/styles/mw.echo.ui.DatedNotificationsWidget.less
@@ -1,6 +1,14 @@
.mw-echo-ui-datedNotificationsWidget {
min-height: 5em;
+ // We want everything inside the widget to be
+ // pending/transparent, but not the widget itself
+ // because otherwise, the background pending animation
+ // is also transparent.
+ &.oo-ui-pendingElement-pending > * {
+ opacity: 0.5;
+ }
+
.mw-echo-ui-subGroupListWidget {
// This is a hack to make sure that this widget
// is the nearest scrollable widget for the submenus
diff --git a/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
b/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
index b9dbe44..fdd6c3e 100644
--- a/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
@@ -1,8 +1,4 @@
.mw-echo-ui-notificationsInboxWidget {
- &.oo-ui-pendingElement-pending .mw-echo-ui-datedSubGroupListWidget {
- opacity: 0.5;
- }
-
&-toolbar {
&-row {
display: table-row;
diff --git a/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
b/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
index 22076c4..1e5f0f8 100644
--- a/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
@@ -35,6 +35,7 @@
$overlay: this.$overlay
}
);
+ this.setPendingElement( this.datedListWidget.$element );
// Pagination
// TODO: Separate the pagination controls and labels to
--
To view, visit https://gerrit.wikimedia.org/r/291852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82b073c9cd628f30c13305510d6604e3ef636c2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
