jenkins-bot has submitted this change and it was merged.
Change subject: Fix opacity on load in IE & Edge
......................................................................
Fix opacity on load in IE & Edge
Divs can not be directly inside <table>
elements, and apparently IE11 and Edge will thus
put these elements somewhere else / throw them away
/ do different things to other browsers.
Thus add the div to a row!
Bug: T134983
Change-Id: I1ad38298fc0d4ec7e6f45cb77ac0100900df9bd1
---
M modules/ext.RevisionSlider.DiffPage.js
M modules/ext.RevisionSlider.css
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index 63b6dab..2872170 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -5,7 +5,7 @@
$.extend( DiffPage.prototype, {
refresh: function ( revId1, revId2 ) {
$( 'table.diff[data-mw=\'interface\']' )
- .append( '<div
id="revision-slider-darkness"></div>' );
+ .append( '<tr><td><div
id="revision-slider-darkness"></div></td></tr>' );
$.ajax( {
url: mw.util.wikiScript( 'index' ),
data: {
diff --git a/modules/ext.RevisionSlider.css b/modules/ext.RevisionSlider.css
index 0c0509e..8cdcefb 100755
--- a/modules/ext.RevisionSlider.css
+++ b/modules/ext.RevisionSlider.css
@@ -136,10 +136,12 @@
#revision-slider-darkness {
background-color: white;
- filter:alpha(opacity=50); /* IE */
- opacity: 0.5; /* Safari, Opera */
- -moz-opacity:0.50; /* FireFox */
- z-index: 20;
+ filter:alpha(opacity=50); /* IE 5-7 */
+ -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=50)"; /* IE 8
*/
+ -khtml-opacity: 0.5; /* Safari 1.x */
+ -moz-opacity:0.50; /* Netscape */
+ opacity: 0.5; /* Good browsers */
+ z-index: 200000;
height: 100%;
width: 100%;
background-repeat:no-repeat;
--
To view, visit https://gerrit.wikimedia.org/r/291711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ad38298fc0d4ec7e6f45cb77ac0100900df9bd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
