Cmcmahon has submitted this change and it was merged. Change subject: Removed line that does nothing ......................................................................
Removed line that does nothing page.search_box_element always returns Watir::TextField, RSpec matcher considers that a "true value", and always passes. If a check is required here, then it should be: page.search_box_element.should exist Change-Id: I77dfb1bdf0e19c1767aa5506b982db4793dbf0e2 --- M tests/acceptance/features/step_definitions/watchlist_steps.rb 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Cmcmahon: Verified; Looks good to me, approved JGonera: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/45179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77dfb1bdf0e19c1767aa5506b982db4793dbf0e2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Mgrover <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
