WMDE-leszek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291915
Change subject: Do not fail when name of the user performing the revision is
not available
......................................................................
Do not fail when name of the user performing the revision is not available
For example when user name is not visible due to RevisionDelete the script
crashed. This makes is check if there is a user name defined and not try
to show it if there is none.
Bug: T135198
Change-Id: I43ce0e49e13ad6262cc60fd938c486ea3e328e64
---
M modules/ext.RevisionSlider.RevisionListView.js
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/15/291915/1
diff --git a/modules/ext.RevisionSlider.RevisionListView.js
b/modules/ext.RevisionSlider.RevisionListView.js
index eee289b..f3f3644 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -56,9 +56,11 @@
var $tooltip = $( '<div>' )
.append(
$( '<p>' ).append( $( '<b>' ).text(
rev.getFormattedDate() ) ),
- $( '<bdi>' ).append( $( '<p>' ).text(
- mw.msg(
'revisionslider-label-user', mw.html.escape( rev.getUser() ) )
- ) ),
+ rev.getUser() ?
+ $( '<bdi>' ).append( $( '<p>'
).text(
+ mw.msg(
'revisionslider-label-user', mw.html.escape( rev.getUser() ) )
+ ) )
+ : '',
rev.getComment() ?
$( '<bdi>' ).append(
$( '<p>' ).append( $(
'<i>' ).text(
--
To view, visit https://gerrit.wikimedia.org/r/291915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43ce0e49e13ad6262cc60fd938c486ea3e328e64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
