Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291917
Change subject: jQuery usage tweaks
......................................................................
jQuery usage tweaks
Use .text() instead of .html() where unneeded, use .parseHTML()
and .val() instead of concatenating user input and using $().
Change-Id: Ideeedbdb2eb17ee36d18f363496e46c818e48046
---
M resources/infrastructure/campaignManager.js
M resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
2 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/17/291917/1
diff --git a/resources/infrastructure/campaignManager.js
b/resources/infrastructure/campaignManager.js
index 10d7ded..8372310 100644
--- a/resources/infrastructure/campaignManager.js
+++ b/resources/infrastructure/campaignManager.js
@@ -39,7 +39,7 @@
slide: function ( event, element ) {
var val = Number( element.value ),
rounded = Math.round( val * 10 ) / 10;
- $( '#centralnotice-throttle-echo' ).html( String(
rounded ) + '%' );
+ $( '#centralnotice-throttle-echo' ).text( String(
rounded ) + '%' );
$( '#centralnotice-throttle-cur' ).val( val );
}
} );
diff --git
a/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
b/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
index 99eb51b..7de7862 100644
--- a/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
+++ b/resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js
@@ -79,22 +79,24 @@
function submitChanges() {
var $form = $( '<form method="post"></form>' ),
- $authtokenField = $(
- '<input type="hidden" name="authtoken" value="'
+
- mw.user.tokens.get( 'editToken' ) +
- '"></input>'
+ $authtokenField = $.parseHTML(
+ '<input type="hidden" name="authtoken" />'
),
- $summaryField = $(
- '<input type="hidden" name="changeSummary"
value="' +
- $( '#cn-campaign-pager
input.cn-change-summary-input' ).val() +
- '"></input>'
+ $summaryField = $.parseHTML(
+ '<input type="hidden" name="changeSummary" />'
),
- $changesField =
- $( '<input type="hidden" name="changes"
></input>' );
+ $changesField = $.parseHTML(
+ '<input type="hidden" name="changes" />'
+ );
+ $authtokenField.val( mw.user.tokens.get( 'editToken' ) );
+ $summaryField.val(
+ $( '#cn-campaign-pager input.cn-change-summary-input'
).val()
+ );
$changesField.val( JSON.stringify( changes ) );
+
$form.append( $authtokenField, $summaryField, $changesField );
$( document.body ).append( $form );
$form.submit();
--
To view, visit https://gerrit.wikimedia.org/r/291917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ideeedbdb2eb17ee36d18f363496e46c818e48046
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
