Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291920
Change subject: In search results, hide description when there's a redirect
source.
......................................................................
In search results, hide description when there's a redirect source.
Bug: T129958
Change-Id: I8afbfece88f24c5da6655c0f3ef5a8e7dacc9fd1
---
M app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/20/291920/1
diff --git a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
index 0dd92b7..b5ee8a7 100644
--- a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
@@ -471,11 +471,16 @@
TextView pageTitleText = (TextView)
convertView.findViewById(R.id.page_list_item_title);
SearchResult result = (SearchResult) getItem(position);
+ GoneIfEmptyTextView descriptionText = (GoneIfEmptyTextView)
convertView.findViewById(R.id.page_list_item_description);
+ descriptionText.setText(result.getTitle().getDescription());
+
View redirectContainer =
convertView.findViewById(R.id.page_list_item_redirect_container);
if (TextUtils.isEmpty(result.getRedirectFrom())) {
redirectContainer.setVisibility(View.GONE);
+ descriptionText.setVisibility(View.VISIBLE);
} else {
redirectContainer.setVisibility(View.VISIBLE);
+ descriptionText.setVisibility(View.GONE);
TextView redirectText = (TextView)
convertView.findViewById(R.id.page_list_item_redirect);
redirectText.setText(String.format(getString(R.string.search_redirect_from),
result.getRedirectFrom()));
}
@@ -494,9 +499,6 @@
} else {
pageTitleText.setText(displayText);
}
-
- GoneIfEmptyTextView descriptionText = (GoneIfEmptyTextView)
convertView.findViewById(R.id.page_list_item_description);
- descriptionText.setText(result.getTitle().getDescription());
ViewUtil.loadImageUrlInto((SimpleDraweeView)
convertView.findViewById(R.id.page_list_item_image),
result.getTitle().getThumbUrl());
--
To view, visit https://gerrit.wikimedia.org/r/291920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8afbfece88f24c5da6655c0f3ef5a8e7dacc9fd1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
