jenkins-bot has submitted this change and it was merged.
Change subject: ve.init.MWWelcomeDialog: Fix keyboard focus on dialog actions
......................................................................
ve.init.MWWelcomeDialog: Fix keyboard focus on dialog actions
Just remove the setTimeout() call. See the task for explanation.
Bug: T135808
Change-Id: I24509046999ef06cef27adb9266167af29d5f76b
(cherry picked from commit 3dfd203d1b0daddc26d6260dfcaeebfec521f3f2)
---
M modules/ve-mw/init/ve.init.MWWelcomeDialog.js
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Dereckson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.MWWelcomeDialog.js
b/modules/ve-mw/init/ve.init.MWWelcomeDialog.js
index 63dddbb..038d579 100644
--- a/modules/ve-mw/init/ve.init.MWWelcomeDialog.js
+++ b/modules/ve-mw/init/ve.init.MWWelcomeDialog.js
@@ -84,15 +84,12 @@
* @inheritdoc
*/
mw.libs.ve.WelcomeDialog.prototype.getReadyProcess = function () {
- var dialog = this;
if ( !this.switchable ) {
// ew
this.actions.remove( this.actions.get( { actions: 'switch-wte'
} ) );
this.actions.remove( this.actions.get( { actions: 'switch-ve' }
) );
}
- setTimeout( function () {
- dialog.actions.setMode( dialog.editor );
- }, 0 );
+ this.actions.setMode( this.editor );
return mw.libs.ve.WelcomeDialog.super.prototype.getReadyProcess.apply(
this, arguments );
};
--
To view, visit https://gerrit.wikimedia.org/r/292044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24509046999ef06cef27adb9266167af29d5f76b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.28.0-wmf.3
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
