jenkins-bot has submitted this change and it was merged.

Change subject: Fix fatal error in our SkinTemplateNavigation handler
......................................................................


Fix fatal error in our SkinTemplateNavigation handler

I must've been testing with some state that didn't trigger this

Change-Id: I6e74ea8c23b0a37fd7e808a66484d5b547b1f844
---
M VisualEditor.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 30145ed..4cc84e7 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -272,7 +272,7 @@
                $title = $skin->getRelevantTitle();
                $namespaceEnabled = ApiVisualEditor::isAllowedNamespace( 
$config, $title->getNamespace() );
                $pageContentModel = $title->getContentModel();
-               $contentModelEnabled = ApiVisualEditor::isAllowedContentType( 
$veConfig, $pageContentModel );
+               $contentModelEnabled = ApiVisualEditor::isAllowedContentType( 
$config, $pageContentModel );
                // Don't exit if this page isn't VE-enabled, since we should 
still
                // change "Edit" to "Edit source".
                $isAvailable = $namespaceEnabled && $contentModelEnabled;

-- 
To view, visit https://gerrit.wikimedia.org/r/292066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e74ea8c23b0a37fd7e808a66484d5b547b1f844
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to