Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/292077
Change subject: SpecialNewpages: Use LinkRenderer instead of Linker::link()
......................................................................
SpecialNewpages: Use LinkRenderer instead of Linker::link()
Change-Id: I78403b7c24253ba44c256f307559400923cc16a6
---
M includes/specials/SpecialNewpages.php
1 file changed, 20 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/77/292077/1
diff --git a/includes/specials/SpecialNewpages.php
b/includes/specials/SpecialNewpages.php
index c24b054..16b291c 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -20,6 +20,8 @@
* @file
* @ingroup SpecialPage
*/
+use MediaWiki\Linker\LinkRenderer;
+use MediaWiki\MediaWikiServices;
/**
* A special page that list newly created pages
@@ -34,6 +36,11 @@
protected $customFilters;
protected $showNavigation = false;
+
+ /**
+ * @var LinkRenderer
+ */
+ private $linkRenderer;
public function __construct() {
parent::__construct( 'Newpages' );
@@ -124,6 +131,8 @@
$this->setHeaders();
$this->outputHeader();
+ $this->linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
+
$this->showNavigation = !$this->including(); // Maybe changed
in setup
$this->setup( $par );
@@ -190,7 +199,10 @@
$self = $this->getPageTitle();
foreach ( $filters as $key => $msg ) {
$onoff = 1 - $this->opts->getValue( $key );
- $link = Linker::link( $self, $showhide[$onoff], [],
+ $link = $this->linkRenderer->makeLink(
+ $self,
+ new HtmlArmor( $showhide[$onoff] ),
+ [],
[ $key => $onoff ] + $changed
);
$links[$key] = $this->msg( $msg )->rawParams( $link
)->escaped();
@@ -307,28 +319,24 @@
$spanTime = Html::element( 'span', [ 'class' =>
'mw-newpages-time' ],
$lang->userTimeAndDate( $result->rc_timestamp,
$this->getUser() )
);
- $time = Linker::linkKnown(
+ $time = $this->linkRenderer->makeKnownLink(
$title,
- $spanTime,
+ new HtmlArmor( $spanTime ),
[],
- [ 'oldid' => $result->rc_this_oldid ],
- []
+ [ 'oldid' => $result->rc_this_oldid ]
);
$query = $title->isRedirect() ? [ 'redirect' => 'no' ] : [];
- // Linker::linkKnown() uses 'known' and 'noclasses' options.
- // This breaks the colouration for stubs.
- $plink = Linker::link(
+ $plink = $this->linkRenderer->makeKnownLink(
$title,
null,
[ 'class' => 'mw-newpages-pagename' ],
- $query,
- [ 'known' ]
+ $query
);
- $histLink = Linker::linkKnown(
+ $histLink = $this->linkRenderer->makeKnownLink(
$title,
- $this->msg( 'hist' )->escaped(),
+ $this->msg( 'hist' )->text(),
[],
[ 'action' => 'history' ]
);
--
To view, visit https://gerrit.wikimedia.org/r/292077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78403b7c24253ba44c256f307559400923cc16a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
