jenkins-bot has submitted this change and it was merged.
Change subject: Make $url parameter to Parser::getExternalLinkAttribs() required
......................................................................
Make $url parameter to Parser::getExternalLinkAttribs() required
All callers in Gerrit pass $url in.
Change-Id: I36246f6510db414dcc7023f8779796c060c3eba5
---
M includes/parser/Parser.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 17098f7..66298b0 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -1882,11 +1882,11 @@
* (depending on configuration, namespace, and the URL's domain) and/or
a
* target attribute (depending on configuration).
*
- * @param string|bool $url Optional URL, to extract the domain from for
rel =>
+ * @param string $url URL to extract the domain from for rel =>
* nofollow if appropriate
* @return array Associative array of HTML attributes
*/
- public function getExternalLinkAttribs( $url = false ) {
+ public function getExternalLinkAttribs( $url ) {
$attribs = [];
$rel = self::getExternalLinkRel( $url, $this->mTitle );
--
To view, visit https://gerrit.wikimedia.org/r/292082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36246f6510db414dcc7023f8779796c060c3eba5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
