[MediaWiki-commits] [Gerrit] Parser: Pass Title onto Linker::makeExternalLink() - change (mediawiki/core)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292085

Change subject: Parser: Pass Title onto Linker::makeExternalLink()
......................................................................

Parser: Pass Title onto Linker::makeExternalLink()

Otherwise $wgNoFollowNsExceptions functionality won't work.

Change-Id: I2e1c5ad41f94568bff7f24a400d555b604cfe22e
---
M includes/parser/Parser.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/292085/1

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 66298b0..116b274 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -1459,7 +1459,7 @@
                                        substr( $m[0], 0, 20 ) . '"' );
                        }
                        $url = wfMessage( $urlmsg, $id 
)->inContentLanguage()->text();
-                       return Linker::makeExternalLink( $url, "{$keyword} 
{$id}", true, $cssClass );
+                       return Linker::makeExternalLink( $url, "{$keyword} 
{$id}", true, $cssClass, [], $this->mTitle );
                } elseif ( isset( $m[6] ) && $m[6] !== '' ) {
                        # ISBN
                        $isbn = $m[6];
@@ -1547,7 +1547,7 @@
                        $text = Linker::makeExternalLink( $url,
                                
$this->getConverterLanguage()->markNoConversion( $url, true ),
                                true, 'free',
-                               $this->getExternalLinkAttribs( $url ) );
+                               $this->getExternalLinkAttribs( $url ), 
$this->mTitle );
                        # Register it in the output object...
                        # Replace unnecessary URL escape codes with their 
equivalent characters
                        $pasteurized = self::normalizeLinkUrl( $url );
@@ -1844,7 +1844,7 @@
                        # Funny characters like ö aren't valid in URLs anyway
                        # This was changed in August 2004
                        $s .= Linker::makeExternalLink( $url, $text, false, 
$linktype,
-                               $this->getExternalLinkAttribs( $url ) ) . 
$dtrail . $trail;
+                               $this->getExternalLinkAttribs( $url ), 
$this->mTitle ) . $dtrail . $trail;
 
                        # Register link in the output object.
                        # Replace unnecessary URL escape codes with the 
referenced character

-- 
To view, visit https://gerrit.wikimedia.org/r/292085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e1c5ad41f94568bff7f24a400d555b604cfe22e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits