jenkins-bot has submitted this change and it was merged.

Change subject: Add parser cache hash key for $wgMFStripResponsiveImages state
......................................................................


Add parser cache hash key for $wgMFStripResponsiveImages state

Prevents leakage of mobile- and desktop-specific renderings into
each other when $wgMFStripResponsiveImages is true (the default).

The hash key '!responsiveimages=0' is chosen to match the currently
used production configuration hack on Wikimedia servers.

Bug: T135553
Change-Id: Id04e50d8dfcbb45b5d2c5655098714dd05d32e65
---
M includes/MobileFrontend.hooks.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 7c92ca5..f88cfac 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -385,6 +385,10 @@
                        return;
                }
 
+               if ( $context->getMFConfig()->get( 'MFStripResponsiveImages' ) 
) {
+                       $confstr .= '!responsiveimages=0';
+               }
+
                if ( $context->isLazyLoadImagesEnabled() ) {
                        $confstr .= '!lazyloadimages';
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/287794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id04e50d8dfcbb45b5d2c5655098714dd05d32e65
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to