Ejegg has submitted this change and it was merged.
Change subject: Revert "ext.centralNotice.display: API for registering tests"
......................................................................
Revert "ext.centralNotice.display: API for registering tests"
This reverts commit 88137bbe7e098385e0711e0ba72fd326e4e395d9.
Bug: T136387
Change-Id: I674fa3580097429655cfae88b8a8169bb403514c
---
M resources/subscribing/ext.centralNotice.display.js
M resources/subscribing/ext.centralNotice.display.state.js
2 files changed, 0 insertions(+), 30 deletions(-)
Approvals:
Ejegg: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/subscribing/ext.centralNotice.display.js
b/resources/subscribing/ext.centralNotice.display.js
index aa6674b..755a044 100644
--- a/resources/subscribing/ext.centralNotice.display.js
+++ b/resources/subscribing/ext.centralNotice.display.js
@@ -542,15 +542,6 @@
},
/**
- * Register that the current page view is included in a test.
- * @param {string} identifier A string to identify the test.
Should not contain
- * commas.
- */
- registerTest( identifier ) {
- cn.internal.state.registerTest( identifier );
- },
-
- /**
* Get the value of a property used in campaign/banner
selection and
* display, and for recording the results of that process.
*/
diff --git a/resources/subscribing/ext.centralNotice.display.state.js
b/resources/subscribing/ext.centralNotice.display.state.js
index bb27ac9..db369ad 100644
--- a/resources/subscribing/ext.centralNotice.display.state.js
+++ b/resources/subscribing/ext.centralNotice.display.state.js
@@ -221,7 +221,6 @@
if ( cleanForURLSerialization ) {
delete dataCopy.getVars;
delete dataCopy.mixins;
- delete dataCopy.tests;
}
return dataCopy;
@@ -351,26 +350,6 @@
setRecordImpressionSampleRate: function( rate ) {
state.data.recordImpressionSampleRate = rate;
- },
-
- /**
- * Register that the current page view is included in a test.
- * @param {string} identifier A string to identify the test.
Should not contain
- * commas.
- */
- registerTest( identifier ) {
- var tests = state.data.tests = state.data.tests || [];
-
- // Add if it isn't already registered.
- if ( $.inArray( identifier, tests ) === -1 ) {
- tests.push( identifier );
-
- if ( tests.length === 1 ) {
- state.data.testIdentifiers = identifier;
- } else {
- state.data.testIdentifiers.concat( ','
+ identifier );
- }
- }
},
lookupReasonCode: function( reasonName ) {
--
To view, visit https://gerrit.wikimedia.org/r/292285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I674fa3580097429655cfae88b8a8169bb403514c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: wmf_deploy
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
