jenkins-bot has submitted this change and it was merged.
Change subject: Add comments explaining gc.iframe module
......................................................................
Add comments explaining gc.iframe module
So future neat freaks don't make the same mistake I did.
Bug: T135388
Change-Id: I5a00eaa363b7b5db284afe9daba8b3423b9d7de4
---
M gateway_forms/rapidhtml/RapidHtmlResources.php
M globalcollect_gateway/forms/css/iframe.css
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
XenoRyet: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_forms/rapidhtml/RapidHtmlResources.php
b/gateway_forms/rapidhtml/RapidHtmlResources.php
index 84f50f8..a3820f7 100644
--- a/gateway_forms/rapidhtml/RapidHtmlResources.php
+++ b/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -48,6 +48,10 @@
'localBasePath' => __DIR__ . '/../../globalcollect_gateway/forms',
'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
);
+/**
+ * This is sourced from inside the Ingenico-hosted iframe rather
+ * than referenced from our site. Please do not remove.
+ */
$wgResourceModules[ 'gc.iframe' ] = array(
'styles' => 'css/iframe.css',
'localBasePath' => __DIR__ . '/../../globalcollect_gateway/forms',
diff --git a/globalcollect_gateway/forms/css/iframe.css
b/globalcollect_gateway/forms/css/iframe.css
index 52d442a..71444a2 100644
--- a/globalcollect_gateway/forms/css/iframe.css
+++ b/globalcollect_gateway/forms/css/iframe.css
@@ -1,3 +1,4 @@
+/* Styling for the Ingenico-hosted card entry form */
body#pageGetMissingData {
background-color: transparent;
}
--
To view, visit https://gerrit.wikimedia.org/r/292289
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a00eaa363b7b5db284afe9daba8b3423b9d7de4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
