jenkins-bot has submitted this change and it was merged.
Change subject: Update account creation error browser test for AuthManager
......................................................................
Update account creation error browser test for AuthManager
The account creation form uses HTMLForm so error selectors are
slightly different.
Change-Id: Ieb76460e96e4ba4e789cb91087d9262286b4835f
---
M
tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
M tests/browser/features/support/pages/special_userlogin_page.rb
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
index 6a4bc8b..1f87ef3 100644
---
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
+++
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
@@ -8,7 +8,8 @@
end
Then(/^I should see an error indicating they do not match$/) do
- expect(on(SpecialUserLoginPage).error_box).to match('The passwords you
entered do not match')
+ expect(on(SpecialUserLoginPage).error_box).to match('There are problems with
some of your input.')
+ expect(on(SpecialUserLoginPage).confirm_password_error_box).to match('The
passwords you entered do not match')
end
Then(/^I should still be on the sign-up page$/) do
diff --git a/tests/browser/features/support/pages/special_userlogin_page.rb
b/tests/browser/features/support/pages/special_userlogin_page.rb
index 7c9dce3..b0c7cca 100644
--- a/tests/browser/features/support/pages/special_userlogin_page.rb
+++ b/tests/browser/features/support/pages/special_userlogin_page.rb
@@ -13,7 +13,8 @@
button(:signup_submit, id: 'wpCreateaccount')
a(:create_account_link, id: 'mw-createaccount-join')
div(:message_box, class: 'warningbox')
- div(:error_box, class: 'errorbox')
+ div(:error_box, css: '#userlogin2 > .error')
+ span(:confirm_password_error_box, css: '#wpRetype + .error')
a(:password_reset, title: 'Special:PasswordReset')
# signup specific
--
To view, visit https://gerrit.wikimedia.org/r/292335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb76460e96e4ba4e789cb91087d9262286b4835f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
