Jakob has submitted this change and it was merged.
Change subject: Add resize cursor to pointers
......................................................................
Add resize cursor to pointers
Also prevent cursor flickering when dragging.
Bug: T136099
Bug: T136833
Change-Id: Ie04c5ad9669c1e839b34bc8f649cc9264f70b666
---
M modules/ext.RevisionSlider.PointerView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
3 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Jakob: Verified; Looks good to me, approved
diff --git a/modules/ext.RevisionSlider.PointerView.js
b/modules/ext.RevisionSlider.PointerView.js
index fb26f54..a224944 100644
--- a/modules/ext.RevisionSlider.PointerView.js
+++ b/modules/ext.RevisionSlider.PointerView.js
@@ -20,7 +20,9 @@
$html: null,
initialize: function () {
- this.$html = $( '<div>' ).attr( 'id', this.id
).addClass( 'mw-pointer' );
+ this.$html = $( '<div>' )
+ .attr( 'id', this.id )
+ .addClass( 'mw-pointer mw-pointer-cursor' );
},
/**
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 41e886e..8eeab63 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -126,6 +126,9 @@
axis: 'x',
grid: [ this.revisionWidth, null ],
containment: '.mw-pointer-container',
+ start: function () {
+ $( '.mw-revision-wrapper' ).addClass(
'mw-pointer-cursor' );
+ },
stop: function () {
var $p = $( this ),
pointer = self.whichPointer( $p
),
@@ -142,6 +145,8 @@
self.diffPage.refresh( revId1, revId2 );
self.diffPage.pushState( revId1,
revId2, self );
+
+ $( '.mw-revision-wrapper'
).removeClass( 'mw-pointer-cursor' );
},
drag: function ( event, ui ) {
var newestVisibleRevisionLeftPos =
containerWidth - self.revisionWidth;
diff --git a/modules/ext.RevisionSlider.css b/modules/ext.RevisionSlider.css
index dd2146c..600ec16 100644
--- a/modules/ext.RevisionSlider.css
+++ b/modules/ext.RevisionSlider.css
@@ -129,6 +129,9 @@
height: 13px;
background-repeat: no-repeat;
}
+.mw-pointer-cursor {
+ cursor:ew-resize;
+}
.mw-revisions-older {
float:left;
--
To view, visit https://gerrit.wikimedia.org/r/292531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie04c5ad9669c1e839b34bc8f649cc9264f70b666
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
