Lokal Profil has uploaded a new change for review.
https://gerrit.wikimedia.org/r/292533
Change subject: [DON'T MERGE] Ensure all monuments_config entries are used
......................................................................
[DON'T MERGE] Ensure all monuments_config entries are used
Tests currently fail since the needed cleanup of monuments_config
has not been done.
Also ideally the same test should be done for wlpa AND we should ensure
all entries are either one or the other.
Bug: T136704
Change-Id: I619230e8ce75f87c3606d1be0dcdc1d8f3a06c9e
---
M tests/test_fill_table.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/heritage
refs/changes/33/292533/1
diff --git a/tests/test_fill_table.py b/tests/test_fill_table.py
index 855ba16..7e7060b 100644
--- a/tests/test_fill_table.py
+++ b/tests/test_fill_table.py
@@ -149,6 +149,11 @@
msg = '%s in fill_table_monuments_all not present in monuments_config'
self.assert_all_in(self.data.keys(), self.config_tables, msg=msg)
+ def test_fill_table_monuments_all_config_tables_used(self):
+ """Ensure that all monuments_config tables are used."""
+ msg = '%s in monuments_config not used in fill_table_monuments_all'
+ self.assert_all_in(self.config_tables, self.data.keys(), msg=msg)
+
def test_fill_table_monuments_all_source_in_config(self):
"""Ensure all sources are present in the corresponding config entry."""
for table, dataset in self.data.iteritems():
--
To view, visit https://gerrit.wikimedia.org/r/292533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I619230e8ce75f87c3606d1be0dcdc1d8f3a06c9e
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/heritage
Gerrit-Branch: master
Gerrit-Owner: Lokal Profil <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
