jenkins-bot has submitted this change and it was merged.
Change subject: Use 'noform' error when appropriate
......................................................................
Use 'noform' error when appropriate
Instead of error-default
Change-Id: I99bd506de3fef95816a2394dbfa9cced58e65c7a
---
M gateway_common/gateway.adapter.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
XenoRyet: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index 2d072dd..2b8394e 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -3283,6 +3283,10 @@
} else {
//Invalid form. Go get one that is valid, and squawk in
the error logs.
$new_ff = GatewayFormChooser::getOneValidForm(
$country, $currency, $payment_method, $payment_submethod, $recurring, $gateway
);
+ if ( empty( $new_ff ) && $this->getGlobal( 'RapidFail'
) ) {
+ // No valid form exists and we want to display
an error without a redirect
+ $new_ff = 'error-noform';
+ }
$this->addRequestData( array ( 'ffname' => $new_ff ) );
//now construct a useful error message
--
To view, visit https://gerrit.wikimedia.org/r/292757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99bd506de3fef95816a2394dbfa9cced58e65c7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
