Aaron Schulz has submitted this change and it was merged.
Change subject: Avoid rollback and bot flagged edits in edit stash stats
......................................................................
Avoid rollback and bot flagged edits in edit stash stats
This just skews the numbers with cases that could not use
the cache anyway.
Bug: T136678
Change-Id: Iaa90d4f6ee80e886f59bc43a1392e59fe2a8f900
---
M includes/page/WikiPage.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index cf533d6..13e5f14 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -1628,7 +1628,8 @@
}
// Get the pre-save transform content and final parser output
- $editInfo = $this->prepareContentForEdit( $content, null,
$user, $serialFormat );
+ $useCache = !( $flags & EDIT_FORCE_BOT ); // avoid statsd noise
(T136678)
+ $editInfo = $this->prepareContentForEdit( $content, null,
$user, $serialFormat, $useCache );
$pstContent = $editInfo->pstContent; // Content object
$meta = [
'bot' => ( $flags & EDIT_FORCE_BOT ),
--
To view, visit https://gerrit.wikimedia.org/r/292520
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa90d4f6ee80e886f59bc43a1392e59fe2a8f900
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
