Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293047

Change subject: Include title in parseAndStash() log messages
......................................................................

Include title in parseAndStash() log messages

Change-Id: I49d61d9cfc5edacf415f6822cb50cc9007735a27
---
M includes/api/ApiStashEdit.php
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/47/293047/1

diff --git a/includes/api/ApiStashEdit.php b/includes/api/ApiStashEdit.php
index e739e51..d5b4da3 100644
--- a/includes/api/ApiStashEdit.php
+++ b/includes/api/ApiStashEdit.php
@@ -145,9 +145,10 @@
 
                $format = $content->getDefaultFormat();
                $editInfo = $page->prepareContentForEdit( $content, null, 
$user, $format, false );
+               $title = $page->getTitle();
 
                if ( $editInfo && $editInfo->output ) {
-                       $key = self::getStashKey( $page->getTitle(), $content, 
$user );
+                       $key = self::getStashKey( $title, $content, $user );
 
                        // Let extensions add ParserOutput metadata or warm 
other caches
                        Hooks::run( 'ParserOutputStashForEdit', [ $page, 
$content, $editInfo->output ] );
@@ -162,14 +163,14 @@
                        if ( $stashInfo ) {
                                $ok = $cache->set( $key, $stashInfo, $ttl );
                                if ( $ok ) {
-                                       $logger->debug( "Cached parser output 
for key '$key'." );
+                                       $logger->debug( "Cached parser output 
for key '$key' ('$title')." );
                                        return self::ERROR_NONE;
                                } else {
-                                       $logger->error( "Failed to cache parser 
output for key '$key'." );
+                                       $logger->error( "Failed to cache parser 
output for key '$key' ('$title')." );
                                        return self::ERROR_CACHE;
                                }
                        } else {
-                               $logger->info( "Uncacheable parser output for 
key '$key'." );
+                               $logger->info( "Uncacheable parser output for 
key '$key' ('$title')." );
                                return self::ERROR_UNCACHEABLE;
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/293047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49d61d9cfc5edacf415f6822cb50cc9007735a27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to