jenkins-bot has submitted this change and it was merged.
Change subject: MediaWiki theme: Fix ToggleSwitchWidget's grip circle shape
......................................................................
MediaWiki theme: Fix ToggleSwitchWidget's grip circle shape
Introducing `min-width` and `min-height` as long as we have to deal
with `em` and its rounding errors.
Bug: T136772
Change-Id: I8f2f2de9300a3692511798bd8c852f381453bc4f
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/widgets.less
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 1dbe2f5..bc421c5 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -43,6 +43,7 @@
@size-indicator-min: 12px;
@size-icon: unit( 24 / 16 / 0.8, em );
@size-indicator: unit( 12 / 16 / 0.8, em );
+@size-toggleswitch-grip-min: 16px;
@border-default: 1px solid #ccc;
@border-radius-default: 2px;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 1be715e..f1134d4 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -1253,7 +1253,9 @@
&-grip {
top: 0.35em;
+ min-width: @size-toggleswitch-grip-min;
width: 1.2em;
+ min-height: @size-toggleswitch-grip-min;
height: 1.2em;
border-radius: 1.2em;
background-color: #555;
--
To view, visit https://gerrit.wikimedia.org/r/292294
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f2f2de9300a3692511798bd8c852f381453bc4f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
