DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293531
Change subject: ProcessDialog: Change DOM ordering of actions
......................................................................
ProcessDialog: Change DOM ordering of actions
Absolute positioning means this only affects the order we'll be tabbing
through them in.
Bug: T129794
Change-Id: Iba2205e32bbc8c4466e77a47c7da7a24e34d5b64
---
M src/dialogs/ProcessDialog.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/31/293531/1
diff --git a/src/dialogs/ProcessDialog.js b/src/dialogs/ProcessDialog.js
index 466ca28..db92241 100644
--- a/src/dialogs/ProcessDialog.js
+++ b/src/dialogs/ProcessDialog.js
@@ -151,7 +151,11 @@
.append( this.$errors );
this.$navigation
.addClass( 'oo-ui-processDialog-navigation' )
- .append( this.$safeActions, this.$location,
this.$primaryActions );
+ // Note: Order of appends below is important. These are in the
order
+ // we want tab to go through them. Display-order is handled
entirely
+ // by CSS absolute-positioning. As such, primary actions like
"done"
+ // should go first.
+ .append( this.$primaryActions, this.$location,
this.$safeActions );
this.$head.append( this.$navigation );
this.$foot.append( this.$otherActions );
};
--
To view, visit https://gerrit.wikimedia.org/r/293531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba2205e32bbc8c4466e77a47c7da7a24e34d5b64
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
