Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293537

Change subject: Fix 'Other ways to give' link in error pages
......................................................................

Fix 'Other ways to give' link in error pages

Bug: T131995
Change-Id: I0be6df78491ce33a1ec40927e484342d61f493ab
---
M gateway_forms/MustacheErrorForm.php
M gateway_forms/mustache/error_form.html.mustache
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/37/293537/1

diff --git a/gateway_forms/MustacheErrorForm.php 
b/gateway_forms/MustacheErrorForm.php
index 3346610..9e633c7 100644
--- a/gateway_forms/MustacheErrorForm.php
+++ b/gateway_forms/MustacheErrorForm.php
@@ -43,9 +43,9 @@
        }
        
        protected function addMessageParameters( &$data ) {
+               // Add otherways_url
+               $data += $this->getUrls();
                $data['problems_email'] = $this->gateway->getGlobal( 
'ProblemsEmail' );
-               // FIXME: rename getCancelPage
-               $data['ways_to_give'] = ResultPages::getCancelPage( 
$this->gateway );
                // set the appropriate header
                $headers = array(
                        'error-cc' => 'php-response-declined',
diff --git a/gateway_forms/mustache/error_form.html.mustache 
b/gateway_forms/mustache/error_form.html.mustache
index 852bede..5cca389 100644
--- a/gateway_forms/mustache/error_form.html.mustache
+++ b/gateway_forms/mustache/error_form.html.mustache
@@ -4,13 +4,13 @@
                </h2>
         <p>
             {{# error-cc }}
-                {{{ l10n "donate_interface-donate-error-try-again-html" 
ffname_retry ways_to_give problems_email }}}
+                {{{ l10n "donate_interface-donate-error-try-again-html" 
ffname_retry otherways_url problems_email }}}
             {{/ error-cc }}
             {{# error-default }}
                 {{{ l10n "donate_interface-otherways" }}}
             {{/ error-default }}
             {{# error-noform }}
-                {{{ l10n "donate_interface-error-no-form-html" ways_to_give 
problems_email }}}
+                {{{ l10n "donate_interface-error-no-form-html" otherways_url 
problems_email }}}
             {{/ error-noform }}
             {{# maintenance }}
                 {{{ l10n "donate_interface-otherways" }}}

-- 
To view, visit https://gerrit.wikimedia.org/r/293537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0be6df78491ce33a1ec40927e484342d61f493ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to