Hoo man has submitted this change and it was merged.

Change subject: Link property ids to the repo in case they don't have a label
......................................................................


Link property ids to the repo in case they don't have a label

Bug: T120378

Change-Id: I2a44a535cd1303ab43e815e25cbf2f3c324d56fc
---
M includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Hoo man: Verified; Looks good to me, approved



diff --git a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua 
b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
index 45aa680..954f7ba 100644
--- a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
+++ b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
@@ -25,11 +25,13 @@
 
 -- Render a label to the language of the local Wiki.
 -- @param string entityId
--- @return string label or entityId if no label available
+-- @return wikitext label or entityId if no label available
 local labelRenderer = function( entityId )
   local label = mw.wikibase.label( entityId )
-  if label == nil then
-    label = entityId
+  if label ~= nil then
+    label = mw.text.nowiki( label )
+  else
+    label = '[' .. mw.wikibase.getEntityUrl( entityId ) .. ' ' .. entityId .. 
']'
   end
   return label
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/287657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a44a535cd1303ab43e815e25cbf2f3c324d56fc
Gerrit-PatchSet: 19
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to