jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.checkboxtoggle: Run after document ready
......................................................................
mediawiki.checkboxtoggle: Run after document ready
Bug: T131318
Change-Id: I74d7de03e7338affbf7f0013937ec38a30cded27
(cherry picked from commit 870c5e28e672d8b72f328d4d96257a471148fabc)
---
M resources/src/mediawiki/mediawiki.checkboxtoggle.js
1 file changed, 19 insertions(+), 16 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.checkboxtoggle.js
b/resources/src/mediawiki/mediawiki.checkboxtoggle.js
index a2386b3..62760d2 100644
--- a/resources/src/mediawiki/mediawiki.checkboxtoggle.js
+++ b/resources/src/mediawiki/mediawiki.checkboxtoggle.js
@@ -12,25 +12,28 @@
( function ( mw, $ ) {
'use strict';
- var $checkboxes = $( 'li input[type=checkbox]' );
+ $( function () {
+ var $checkboxes = $( 'li input[type=checkbox]' );
- function selectAll( check ) {
- $checkboxes.prop( 'checked', check );
- }
+ function selectAll( check ) {
+ $checkboxes.prop( 'checked', check );
+ }
- $( '.mw-checkbox-all' ).click( function ( e ) {
- selectAll( true );
- e.preventDefault();
- } );
- $( '.mw-checkbox-none' ).click( function ( e ) {
- selectAll( false );
- e.preventDefault();
- } );
- $( '.mw-checkbox-invert' ).click( function ( e ) {
- $checkboxes.each( function () {
- $( this ).prop( 'checked', !$( this ).is( ':checked' )
);
+ $( '.mw-checkbox-all' ).click( function ( e ) {
+ selectAll( true );
+ e.preventDefault();
} );
- e.preventDefault();
+ $( '.mw-checkbox-none' ).click( function ( e ) {
+ selectAll( false );
+ e.preventDefault();
+ } );
+ $( '.mw-checkbox-invert' ).click( function ( e ) {
+ $checkboxes.each( function () {
+ $( this ).prop( 'checked', !$( this ).is(
':checked' ) );
+ } );
+ e.preventDefault();
+ } );
+
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/293545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d7de03e7338affbf7f0013937ec38a30cded27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits