Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/293782
Change subject: Use master DB when touching the user to signal rename end ...................................................................... Use master DB when touching the user to signal rename end Since the user object is updated in the process of the rename, fetching from a lagged slave might result in and outdated user_touched value and thus a CAS error. Bug: T135656 Change-Id: I14e3615ccbcabfdf0dcbf7c098eb0e152ec4a18a (cherry picked from commit 2c9b3f10e2d40df9e3b9b90cd67b159526886a93) --- M RenameuserSQL.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser refs/changes/82/293782/1 diff --git a/RenameuserSQL.php b/RenameuserSQL.php index 3f03211..b594a51 100644 --- a/RenameuserSQL.php +++ b/RenameuserSQL.php @@ -340,6 +340,7 @@ $dbw->setFlag( DBO_TRX ); // Clear caches and inform authentication plugins $user = User::newFromId( $that->uid ); + $user->load( User::READ_LATEST ); // Call $wgAuth for backwards compatibility if ( class_exists( AuthManager::class ) ) { AuthManager::callLegacyAuthPlugin( 'updateExternalDB', [ $user ] ); -- To view, visit https://gerrit.wikimedia.org/r/293782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14e3615ccbcabfdf0dcbf7c098eb0e152ec4a18a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Renameuser Gerrit-Branch: REL1_27 Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits