jenkins-bot has submitted this change and it was merged.
Change subject: Fix "Undefined index: type" warning on LoginSignupSpecialPage
......................................................................
Fix "Undefined index: type" warning on LoginSignupSpecialPage
When discarding form descriptors that do not have an equivalent
AuthenticationRequest field, do not assume the descriptor always
has a type.
Th warning was probably caused by I2a8cd4850.
Change-Id: Id1daee1e4954199fcb2077178e8f08d1ad3ae916
(cherry picked from commit 4d226cbeb914f01d37a28b0ff78b60fef1cd653e)
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specialpage/LoginSignupSpecialPage.php
b/includes/specialpage/LoginSignupSpecialPage.php
index c7aed77..07cedca 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -865,7 +865,7 @@
!isset( $coreField['baseField'] )
|| !isset(
$fieldInfo[$coreField['baseField']] )
) && !in_array( $fieldName, $specialFields,
true )
- && $coreField['type'] !== 'submit'
+ && ( !isset( $coreField['type'] ) ||
$coreField['type'] !== 'submit' )
) {
$coreFieldDescriptors[$fieldName] = null;
continue;
--
To view, visit https://gerrit.wikimedia.org/r/293778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1daee1e4954199fcb2077178e8f08d1ad3ae916
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
