Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293786
Change subject: Use $tablesUsed rather than manually deleting all rows from the
'user' table
......................................................................
Use $tablesUsed rather than manually deleting all rows from the 'user' table
Bug: T132411
Change-Id: I901138b73d2b38cab273af43493393574f7c4091
(cherry picked from commit 953e205d8969f099f80055a1de1b13df1f564271)
---
M tests/SpoofUserTest.php
1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AntiSpoof
refs/changes/86/293786/1
diff --git a/tests/SpoofUserTest.php b/tests/SpoofUserTest.php
index 8e5cf4f..51388c2 100644
--- a/tests/SpoofUserTest.php
+++ b/tests/SpoofUserTest.php
@@ -5,6 +5,8 @@
*/
class SpoofUserTest extends MediaWikiTestCase {
+ protected $tablesUsed = [ 'user', 'spoofuser' ];
+
private static $usernames = array(
'UserFoo',
'UserF00',
@@ -30,14 +32,6 @@
$s = new SpoofUser( 'NotInTheUserTable' );
$s->record();
- }
-
- public function tearDown() {
- $dbw = wfGetDB( DB_MASTER );
- // Clean up the mess we made...
- $dbw->delete( 'user', '*', __METHOD__ );
- $dbw->delete( 'spoofuser', '*', __METHOD__ );
- parent::tearDown();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/293786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I901138b73d2b38cab273af43493393574f7c4091
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AntiSpoof
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
