jenkins-bot has submitted this change and it was merged.
Change subject: Set doesWrites() for FlowAction
......................................................................
Set doesWrites() for FlowAction
This avoids bogus warnings on POST in the DBPerformance log
Change-Id: Ib6049d867ee87235b6b76bd883c108809fb00cad
---
M includes/Actions/Action.php
M includes/Actions/ViewAction.php
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Actions/Action.php b/includes/Actions/Action.php
index 516fca8..ae81034 100644
--- a/includes/Actions/Action.php
+++ b/includes/Actions/Action.php
@@ -35,6 +35,10 @@
$this->actionName = $actionName;
}
+ public function doesWrites() {
+ return true;
+ }
+
/**
* @return string
*/
diff --git a/includes/Actions/ViewAction.php b/includes/Actions/ViewAction.php
index f418817..9a1d9ae 100644
--- a/includes/Actions/ViewAction.php
+++ b/includes/Actions/ViewAction.php
@@ -12,6 +12,10 @@
parent::__construct( $page, $context, 'view' );
}
+ public function doesWrites() {
+ return false;
+ }
+
public function showForAction( $action, OutputPage $output = null ) {
parent::showForAction( $action, $output );
--
To view, visit https://gerrit.wikimedia.org/r/293675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6049d867ee87235b6b76bd883c108809fb00cad
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
