jenkins-bot has submitted this change and it was merged.
Change subject: Remove old config hack that disabled $wgResponsiveImages on
mobile
......................................................................
Remove old config hack that disabled $wgResponsiveImages on mobile
This config hack should no longer be needed since MobileFrontend
started stripping srcset attributes itself. Once Icc1246e2b109e4
merges as well, there will be a native parser cache hash key element
for keeping the mobile and desktop entries separate, so the explicit
appending to the key should no longer be needed and would result in
doubling up.
Change-Id: I3d8155d7e147608ed239ac210fdc8d7222a76b16
Depends-On: Icc1246e2b109e4
---
M wmf-config/mobile.php
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wmf-config/mobile.php b/wmf-config/mobile.php
index 53d9271..bc046c9 100644
--- a/wmf-config/mobile.php
+++ b/wmf-config/mobile.php
@@ -66,17 +66,10 @@
$wgMFNoMobilePages = $wmgMFNoMobilePages;
$wgHooks['EnterMobileMode'][] = function() {
- global $wgCentralAuthCookieDomain, $wgHooks,
$wgResponsiveImages, $wgRenderHashAppend,
- $wgIncludeLegacyJavaScript;
+ global $wgCentralAuthCookieDomain, $wgHooks,
$wgIncludeLegacyJavaScript;
// Disable loading of legacy wikibits in the mobile web
experience
$wgIncludeLegacyJavaScript = false;
-
- // Disable responsive images on mobile web (T119797), but not
on apps.
- if ( !defined( 'MW_API' ) ) {
- $wgResponsiveImages = false;
- $wgRenderHashAppend .= '!responsiveimages=0';
- }
// Hack for T49647
if ( $wgCentralAuthCookieDomain == 'commons.wikimedia.org' ) {
@@ -129,7 +122,7 @@
// Turn on volunteer recruitment
$wgMFEnableJSConsoleRecruitment = true;
- // Brute-force bandwidth optimization by stripping srcset
+ // Brute-force bandwidth optimization by stripping srcset (T119797)
$wgMFStripResponsiveImages = true;
}
--
To view, visit https://gerrit.wikimedia.org/r/287818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8155d7e147608ed239ac210fdc8d7222a76b16
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
