Yuvipanda has submitted this change and it was merged.
Change subject: graphite: Do not hardcode hostname into checks
......................................................................
graphite: Do not hardcode hostname into checks
This confuses people
Change-Id: I23af12b86c5c2cab26beb25e5ecd9e08929ddd7d
---
M modules/role/manifests/graphite/base.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ori.livneh: Looks good to me, but someone else must approve
Yuvipanda: Verified; Looks good to me, approved
diff --git a/modules/role/manifests/graphite/base.pp
b/modules/role/manifests/graphite/base.pp
index efb9313..559b8a6 100644
--- a/modules/role/manifests/graphite/base.pp
+++ b/modules/role/manifests/graphite/base.pp
@@ -241,8 +241,8 @@
# This check goes to the backend, which is http.
monitoring::service { 'graphite':
- description => 'graphite.wikimedia.org',
- check_command => 'check_http_url!graphite.wikimedia.org!/render',
+ description => $hostname,
+ check_command => "check_http_url!${hostname}!/render",
}
ferm::service { 'carbon_c_relay-frontend_relay_udp':
--
To view, visit https://gerrit.wikimedia.org/r/293886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23af12b86c5c2cab26beb25e5ecd9e08929ddd7d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
